Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle double digits #43

Open
emilgoldsmith opened this issue Jun 20, 2019 · 2 comments
Open

Doesn't handle double digits #43

emilgoldsmith opened this issue Jun 20, 2019 · 2 comments

Comments

@emilgoldsmith
Copy link

Hi!

Thank you for this plugin it's a nifty little helper. Just wanted to point out that it doesn't handle several digits though. I've just been using it for building a new product right now and until deploying the first MVP we're just using v0.0.x and up to x=13 now, but since we reached x=10 it just gives fatal error v0.0.10 every time you call git semver patch, so we have to do it manually.

I'm assuming it's not too hard if you know bash well, I was trying to look at the code to see if I could do it myself but not a bash guru so it wasn't obvious to me anyway.

@emilgoldsmith
Copy link
Author

Actually just took a quick look, seems it's the sorting that's the problem as the parsing seems okay. Maybe I'll put in a bit more time later and submit a fix, but got to go now

@john-tipper
Copy link

I have pushed a PR (#46) that I believe fixes this (hope it will be merged soon), please let me know if you see further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants