Port stripped on white space (e.g., [Out] Speaker) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had recently found a better solution (and was going to submit it before I saw yours): setting a different field separator (
Maybe you could update your pull request? This would fix #83. |
fabian-thomas
force-pushed
the
fix-portname
branch
from
b5cff3b
to
1be01ad
Compare
|
Yep, let's do that. I added you as co-author. |
|
Oh that's kind! Thank you! |
marioortizmanero
approved these changes
May 18, 2024
When the port is something like "[Out] Speaker" the previous awk call only extracted "[Out]". Co-authored-by: Nicolas Chachereau <nicolas@nchachereau.ch>
marioortizmanero
force-pushed
the
fix-portname
branch
from
1be01ad
to
bc86024
Compare
marioortizmanero
merged commit dd6f72c
into
marioortizmanero:master
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the port is something like "[Out] Speaker" the previous awk call only extracted "[Out]". Now it extracts all fields. I'm not sure if the modified awk call is the best one can use but it works.
Fixes #83