Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #59

Open
4 tasks
marioortizmanero opened this issue Dec 27, 2021 · 0 comments
Open
4 tasks

Code cleanup #59

marioortizmanero opened this issue Dec 27, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@marioortizmanero
Copy link
Owner

marioortizmanero commented Dec 27, 2021

There are many parts of the code that could do with a bit of cleaning up. I would very much appreciate any help on this, I can help out by reviewing any changes:

  • The script includes multiple ways of reading properties:

    1. With a while read in getNicknameFromProp
    2. With a good ol' grep pipe everywhere else

    The first actually seems more robust, but the second is more "bash"-y. I don't really care, anyway. The point is that they should be consistent.

  • getNickname is quite messy. The if statements could surely be simplified in some way. Or it should be commented internally, at least.

  • Overall, many commands are incredibly large and complicated. We could:

    • Split each pipe into a different line with \ so that it's more readable
    • Try to simplify them
  • Put all the simple getter functions at the beginning of the file

If anyone else thinks of other improvements, please leave them as a comment here!

@marioortizmanero marioortizmanero added enhancement New feature or request good first issue Good for newcomers labels Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant