Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast ratio #495

Open
denar90 opened this issue Mar 19, 2017 · 4 comments
Open

Improve contrast ratio #495

denar90 opened this issue Mar 19, 2017 · 4 comments

Comments

@denar90
Copy link
Member

denar90 commented Mar 19, 2017

We have not so good contrast ratio. Using e.g. Lighthouse, we have these results

image

P.S.

https://chrome.google.com/webstore/detail/chromelens/idikgljglpfilbhaboonnpnnincjhjkd
http://leaverou.github.io/contrast-ratio/

might help to improve it

@peterblazejewicz
Copy link
Member

This extension (from Google) adds an option to audits section in dev tools to verify a11y rules. It procies hinted color that should be used instead of one failing tests based on luminosity change. So you could do adjustment pretty mach based on this tool hints:
https://chrome.google.com/webstore/detail/accessibility-developer-t/fpkknkljclfencbdbgkenhalefipecmb?hl=en
The footer is secondary content (always hidden under the fold), so this should be OK to just fix color using hints (for links)
The masthead buttons background color is the other thing. Just check what you get with a11y tool

@denar90
Copy link
Member Author

denar90 commented Mar 27, 2017

thx 👍

@paulfalgout
Copy link
Member

I think we should just ask @samccone to tweak lighthouse so marionettejs.com passes. 🥇

@samccone
Copy link
Member

:) thanks @peterblazejewicz for the detailed response. in this case I think no magic lighthouse hacks are needed :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants