Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDs to sections for easy reference #409

Open
trezy opened this issue May 26, 2015 · 7 comments
Open

Add IDs to sections for easy reference #409

trezy opened this issue May 26, 2015 · 7 comments
Assignees

Comments

@trezy
Copy link
Member

trezy commented May 26, 2015

One of my coworkers asked my yesterday who actually uses Marionette. I just referred him to the list of the bottom of the website but I would rather have been able to send him a link like [http://marionettejs.com/#logos].

@trezy trezy self-assigned this May 26, 2015
@peterblazejewicz
Copy link
Member

👍
But on small screens there will be a hidden trap - the navigation will work (they user will be navigated) but this specific section is hidden on mobile screens.
So if section is to be bookmarkable it has to be accessible.
/cc
@jdaudier

@jdaudier
Copy link
Contributor

@peterblazejewicz Meaning we have to un-hide it for mobile, correct? Just making sure I am on the same page.

thanks @trezy for the idea! I'll see you tomorrow at JSConf.

@peterblazejewicz
Copy link
Member

@jdaudier Yes, just make sure that any header/section with added bookmarkable anchor is visible on all viewports :D

@jdaudier
Copy link
Contributor

you got it!

@trezy
Copy link
Member Author

trezy commented Jun 29, 2015

@peterblazejewicz I disagree. I've verified on several mobile devices -- Android 4.something, Android 4.somethingElse, iOS8, etc -- that the browser just brings you to the top of the homepage if the section is hidden. No unexpected consequences. I'll dig in and add these this weekend since I got the repo to build this time. :-)

@peterblazejewicz
Copy link
Member

@trezy that's the point - user arepointed nowhere:
http://bradfrost.com/blog/post/five-responsive-web-design-pitfalls-to-avoid/

don’t penalise users for the device they happen to be browsing with.

@trezy
Copy link
Member Author

trezy commented Jun 29, 2015

@peterblazejewicz That's an issue with us hiding sections. If you're concerned with users being penalized then we should make sure all of the sections are available, i.e. not hidden from mobile. That's a completely separate issue. This is an enhancement to make the page more navigable for those that have the capability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants