Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation home has wrong title and meta information #381

Open
cmaher opened this issue Mar 18, 2015 · 2 comments
Open

Documentation home has wrong title and meta information #381

cmaher opened this issue Mar 18, 2015 · 2 comments
Labels
bug

Comments

@cmaher
Copy link
Member

cmaher commented Mar 18, 2015

http://marionettejs.com/docs/current/ has title and meta information for Marionette.Application

This can really mess up SEO.
@samccone
Copy link
Member

oh yeah this is no good

@peterblazejewicz
Copy link
Member

If I understand, we are always using file name to set page title (and other things):
https://github.com/marionettejs/marionettejs.com/blob/master/src/docs/template.hbs#L6
so we always passing the first (application) file to render by this template.
Should we introduce hbs partials to split templates and have different template for index page + object for landing docs page?

@samccone samccone added the bug label Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterblazejewicz @samccone @cmaher