Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollectionView reset event should use _removeChildModels #3622

Open
paulfalgout opened this issue Aug 10, 2018 · 0 comments
Open

CollectionView reset event should use _removeChildModels #3622

paulfalgout opened this issue Aug 10, 2018 · 0 comments
Milestone

Comments

@paulfalgout
Copy link
Member

It can iterate over the reset event's previousModels This prevents a collection.reset from removing customly added views.

We should also indicate that child view was created from a collection model rather than using this._children.findByModel to account for views added from a collectionview that do not have the collection's model. We should add a custom index so that we can find children by the custom index. All of this can be private API.

@paulfalgout paulfalgout added this to the v4.x milestone Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant