Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple SwiftUI Warnings on >iOS 16.X #91

Open
leafarenuk opened this issue Nov 20, 2022 · 4 comments
Open

Multiple SwiftUI Warnings on >iOS 16.X #91

leafarenuk opened this issue Nov 20, 2022 · 4 comments
Labels
bug Something isn't working
Projects

Comments

@leafarenuk
Copy link

What problems I want to solve?

There are mutliple warnings on iOS >16.X while using your code:
Publishing changes from within view updates is not allowed, this will cause undefined behavior.

File: CurrencyText/tree/main/Sources
Lines: 73, 122 and 124

CleanShot 2022-11-20 at 01 50 20

What value it delivers?

There will be no more warnings while running the app. Improve stability.

Tasks

TBD

Dependecies / References

No dependencies and/or references by now.

@marinofelipe
Copy link
Owner

Hey @leafarenuk, thanks for the heads up.

So far the project wasn't checked against the latest iOS version and Xcode/Swift toolchains, good to know there is this issues.
I'll try and find some time the next few days to check and have it fixed.
Also, if you feel like trying it out, feel free to do so, I can help with some pointers if needed.

@marinofelipe marinofelipe added this to To do in Kanban via automation Nov 20, 2022
@marinofelipe marinofelipe added the bug Something isn't working label Nov 20, 2022
@Andrewangeta
Copy link

@marinofelipe This should be as simple as wrapping those two assignments operations in a DispatchQueue.main.async I can make a PR if you'd like?

@Andrewangeta
Copy link

@marinofelipe @leafarenuk See #92

@marinofelipe
Copy link
Owner

Thanks a lot @Andrewangeta 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Kanban
  
To do
Development

No branches or pull requests

3 participants