Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eductions are not considered sequential for midje collection checkers #352

Open
cch1 opened this issue Feb 17, 2016 · 2 comments
Open

Eductions are not considered sequential for midje collection checkers #352

cch1 opened this issue Feb 17, 2016 · 2 comments

Comments

@cch1
Copy link
Contributor

cch1 commented Feb 17, 2016

This is unfortunate:

((contains 3) (map inc (range 4))) => true
((contains 3) (eduction (map inc) (range 4))) => false

As more collection processing code moves towards transducers, eductions are a natural next step. Perhaps a mod to standardized-arguments to realize the eduction with seq would work.

@marick
Copy link
Owner

marick commented Feb 18, 2016

That seems reasonable. I'm slowly implementing Midje's collection checkers in https://github.com/marick/structural-typing/ so that they get considerably better error handlers. I've made a note to handle eductions as you suggest.

@marick
Copy link
Owner

marick commented Sep 5, 2016

As I am transitioning away from Clojure to Elixir, it's unlikely this will happen unless someone contributes a pull request. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants