Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to repl triggers all midje tests? #319

Open
arichiardi opened this issue Jul 8, 2015 · 6 comments
Open

Connect to repl triggers all midje tests? #319

arichiardi opened this issue Jul 8, 2015 · 6 comments

Comments

@arichiardi
Copy link

Hello, I am observing a weird behaviour using midje 2.0.0-SNAPSHOT.

Basically my workflow is:

  • Start a lein repl
  • Connect to it from outside (tipically cider's without jacking-in)
  • Work

The thing is, every time I connect to the repl, all the tests are triggered, without even considering my (which work fine with lein midje instead:

(change-defaults :print-level :print-namespaces
                 :fact-filter #(and (not (:slow %1))
                                   (not (:bench %1))
                                   (not (:profile %1))))```

What am I doing wrong? Is this expected?
@marick
Copy link
Owner

marick commented Jul 8, 2015

Does it happen on 1.7? All that's been done with 2.0 so far is moving stuff out into separate libraries.

@arichiardi
Copy link
Author

Yes, just tried, and it runs all the test without even filtering...

@marick
Copy link
Owner

marick commented Jul 10, 2015

So, to make sure I understand: both 1.7 and 2.0 behave the same way: they run all the tests without any change to any file, and they don't obey the :fact-filter?

Since I run (autotest) in an emacs shell buffer (not using Cider), I'm not sure how to interpret your problem. You run lein repl in an ordinary shell? What do you type after that? How do you connect to the repl? (And how often?)

@arichiardi
Copy link
Author

I run lein repl from the shell (and nothing else, on linux) and then connect to it through cider's repl connect. As soon as I see that cider is connected, the repl instance in the shell starts crunching tests, without :fact-filtering. I am sure of it because the filtering works perfectly with lein midje , i.e. I don't see any heavy test.
Is there a way to debug the issue, I can help you with that.

@marick
Copy link
Owner

marick commented Jul 10, 2015

You must type something after lein midje and before connecting. Autotest?

Can you make a video capture of what you're doing. (If on a mac, the quicktime player lets you capture your screen.)

@arichiardi
Copy link
Author

No no my command is lein repl, not lein midje...and then connect to it from cider. .. yes I will record my desktop no problem

On July 10, 2015 9:41:17 PM GMT+02:00, Brian Marick notifications@github.com wrote:

You must type something after lein midje and before connecting.
Autotest?

Can you make a video capture of what you're doing. (If on a mac, the
quicktime player lets you capture your screen.)


Reply to this email directly or view it on GitHub:
#319 (comment)

-ar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants