Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple lines in graph #22

Open
Ami-Gohel opened this issue Jun 14, 2022 · 19 comments
Open

Multiple lines in graph #22

Ami-Gohel opened this issue Jun 14, 2022 · 19 comments
Labels
feature-request New feature requested by the community

Comments

@Ami-Gohel
Copy link

This is not supporting multiple lines in a single chart.

@taatiq882
Copy link

Did you find any solution ? i also require multiple lime graph with sort of same implementation.

@chrispader
Copy link
Member

This is not supported at the moment. Unfortunately, i don't think we plan to implement this feature anytime soon.

If you or somebody could open a PR for this, that would be great. What do you think @mrousavy ?

@chrispader chrispader added the feature-request New feature requested by the community label Sep 12, 2022
@mrousavy
Copy link
Member

I think this requires a few structural changes and is a little bit of work. We don't plan to implement that anytime soon, but if you need this feature developed by us, contact us at hello@margelo.io :)

@sidferreira
Copy link

@mrousavy, would a PR be considered?

@Ami-Gohel
Copy link
Author

I have creates multiple line graphs with SVG, soon I will make package and make open source.

@mrousavy
Copy link
Member

@sidferreira

@mrousavy, would a PR be considered?

Yes! If you shoot me a PR, we can review it :)

@youssdevx
Copy link

@sidferreira a PR would be much appreciated 🙏🏽

@sidferreira
Copy link

@youssdevx although I had some local work, my main need was cancelled, so I don't know when I'll be able to

@youssdevx
Copy link

Could you maybe push your work? I'll try to work on it

@sidferreira
Copy link

I'll try

@sidferreira
Copy link

https://github.com/sidferreira/react-native-graph-tests

https://github.com/sidferreira/react-native-graph/tree/multiple-graphs

What I tried to do is to create a shared const panGesture = usePanGesture({holdDuration: 100}); that is an argument for the graph, and then you can have a main graph and all others (using pointerEvents="none") will follow it

@youssdevx @mrousavy

@sidferreira
Copy link

I also tried to make the graph generic type

@youssdevx
Copy link

I'll look into it, many thanks 🙏🏽

@sidferreira
Copy link

@youssdevx #66 too

@youssdevx
Copy link

I still did have the chance to work on this... @mrousavy do you have plans for this feature?

@youssdevx

This comment was marked as off-topic.

@erics1033
Copy link

Any updates on this feature request?

@youssdevx

This comment was marked as off-topic.

@mrousavy
Copy link
Member

@mrousavy do you have plans for this feature?

No, I don't have the free time to build this for you guys. But if you submit a PR we can review it and merge it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature requested by the community
Projects
None yet
Development

No branches or pull requests

7 participants