Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback on v1 #1

Open
marcusmolchany opened this issue Feb 5, 2022 · 0 comments
Open

feedback on v1 #1

marcusmolchany opened this issue Feb 5, 2022 · 0 comments

Comments

@marcusmolchany
Copy link
Owner

marcusmolchany commented Feb 5, 2022

looking for feedback on v1. all feedback is appreciated.

if you have specific opinions on the following things let me know:

other things that are on my mind:

  • docs or utilities for a secure challenge flow. challenge message should include: nonce, timestamp, human-readable message, domain and chain information.
  • add /examples dir and replit with working examples
  • better api for erc20/721/777 vs erc1155
  • look into Sign-in with Ethereum and EIP-4361
  • support signTypedData()
  • support batchBalanceOf for erc1155
  • allowing for a web3.js provider to be appropriately wrapped by ethers (https://docs.ethers.io/v5/api/providers/other/#Web3Provider)
  • confirming that wallets other than metamask and wallet connect work appropriately
  • separating the signature verification step, and the token gating steps
  • making the token gating step compose multiple token gates. the default token gate utility would be to check for a .balanceOf() for a giving token address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant