[Feature Request] Add or improve history actions

[pySilver]

Thanks for the great lib!

It would be nice to have a shortcut to modify Turbo.navigator.history. I find it an essential action since the Back button is not doing what is expected when the browser history is modified without touching Turbo.navigator.history. As a workaround, the invoke action can be used at the moment.

More on the issue: https://discuss.hotwired.dev/t/back-button-not-working/3012

P.S. I'd really love to help but I'm not very familiar with Typescript yet :/

[marcoroth]

Thanks for opening this!

I'm happy to take a look on adding such an action!

[pySilver]

@marcoroth FYK navigation isn't that simple, unfortunately. See this: hotwired/turbo#792

[marcoroth]

I was wondering if expanding the push_state action would be worth thinking about:

turbo_power/src/actions/history.ts

Lines 3 to 9 in 623a6f5

	export function push_state(this: StreamElement) {
	const url = this.getAttribute("url")
	const state = this.getAttribute("state")
	const title = this.getAttribute("title") || ""
	window.history.pushState(state, title, url)
	}

[pySilver]

Sounds OK if that would let one push state solely on window.history or the Turbo.navigator.history (sometime you want or another)

[marcoroth]

Yeah, I thought it could be similar to how redirect_to works.

turbo_power/src/actions/browser.ts

Lines 17 to 29 in 623a6f5

	export function redirect_to(this: StreamElement) {
	const url = this.getAttribute("url") || "/"
	const action = (this.getAttribute("action") || "advance") as Action
	const turbo = this.getAttribute("turbo") === "true"
	if (turbo) {
	if (window.Turbo) window.Turbo.visit(url, { action })
	if (window.Turbolinks) window.Turbolinks.visit(url, { action })
	if (!window.Turbo && !window.Turbolinks) window.location.href = url
	} else {
	window.location.href = url
	}
	}

By default it uses the one on Turbo, but if you don't want that or if Turbo is not available it falls back to window