Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the depreciated start and end groups types #110

Open
kenttregenza opened this issue Oct 22, 2019 · 1 comment
Open

Implementing the depreciated start and end groups types #110

kenttregenza opened this issue Oct 22, 2019 · 1 comment

Comments

@kenttregenza
Copy link

As indicated here https://developers.google.com/protocol-buffers/docs/encoding The wire types of 3 and 4 (start and end groups) are "depreciated" ... but unfortunately they still exist on some protobuf packets floating around.

This could be easily resolved by adding these types and then update skip to include them (skipping zero bytes):
else if (type === Pbf.StartGroup) this.pos += 0;
else if (type === Pbf.EndGroup) this.pos += 0;

@bulk88
Copy link

bulk88 commented Dec 21, 2020

I agree, googleapis still return start and end groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants