[compose] get annotationManager from PointAnnotationGroup #2357
Conversation
…tureId to use ViewAnnotation
|
|
…`. (mapbox#2357) This reverts commit 848bc996610213ab8101ba2bd601a6d124513d5e. Fix changelog.
| @@ -90,6 +92,7 @@ public fun PointAnnotationGroup( | |||
| iconTranslateAnchor: IconTranslateAnchor? = null, | |||
| textTranslate: List<Double>? = null, | |||
| textTranslateAnchor: TextTranslateAnchor? = null, | |||
| onAnnotationManagerCreated: (PointAnnotationManager) -> Unit = {}, | |||
There was a problem hiding this comment.
Hey @hiroaki404 , thanks for contributing. With the proposed approach, I think you still cannot get the annotation id, as the annotation is supposed to be created by compose and you should not directly call PointAnnotationManager.create().
I think we'd go with exposing the feature id setter in the AnnotationOptions class, as it's more friendly in compose context and also align with iOS implementation. I have created a internal ticket for this feature.
There was a problem hiding this comment.
I think we'd go with exposing the feature id setter in the AnnotationOptions class, as it's more friendly in compose context and also align with iOS implementation. I have created a internal ticket for this feature.
If that's possible, I think it's better too. Thank you!
for get featureId to use ViewAnnotation
Summary of changes
It doesn't work when using the combination of PointAnnotationGroup clustering and ViewAnotation.
When creating ViewAnnotationOptions, you can specify the featureId in annotatedLayerFeature to associate it with PointAnnotation. At this time, featureId is obtained from the Annotation as the return value when calling PointAnnotation.create().
However, when using the Copmose Extension, the PointAnnotationManager is hidden, so the annotation ID cannot be obtained.
As a workaround, you can remember PointAnnotationManager and access annotations property of PointAnnotationManager to get the annotation ID when needed.
Currently, annotation IDs are randomly generated, but another method is to specify an ID and create an annotation. However, I think this method requires a large scale of change.
Please consider the contents.
User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: #2344
PRs must be submitted under the terms of our Contributor License Agreement CLA.