Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate shifting for large polygons #98

Open
gnitsua opened this issue Apr 22, 2018 · 2 comments
Open

Coordinate shifting for large polygons #98

gnitsua opened this issue Apr 22, 2018 · 2 comments
Labels

Comments

@gnitsua
Copy link

gnitsua commented Apr 22, 2018

I am using geobuf for encoding and decoding large geojson polygons for my project and have noticed that there seems to be some sort of error introduced by the encoding that compounds over time. This can result in polygons that are highly inaccurate for large perimeters. I know you guys have an accuracy of 1e6, but I feel like that is not what is causing this. Any help would be greatly appreciated. I am encoding using python and decoding using javascript

encoding_error

The problem:
Results of encoding and decoding geojson seem to change coordinates for polygons with a large number of coordinates

Steps to reproduce:
Github won't let me attach .json files directly, so I have compressed them. One file represents the unencoded data and the other after encoding and decoding with geobuf
geojson.zip

@mourner mourner added the bug label Apr 23, 2018
@mourner
Copy link
Member

mourner commented Apr 23, 2018

Thanks for the report! This might be some kind of bug related to delta-encoding the coordinates. I'll investigate.

@gnitsua
Copy link
Author

gnitsua commented Nov 7, 2018

I think this may be related to pygeobuf/pygeobuf#42 which may mean it is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants