Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Helmet 6 once it is released to avoid maximum call stack error #58

Open
manuelbieh opened this issue May 2, 2019 · 1 comment

Comments

@manuelbieh
Copy link
Owner

When using this:

<Helmet
    defaultTitle="React SSR Starter – TypeScript Edition"
    titleTemplate="%s – React SSR Starter – TypeScript Edition"
>
    <link rel="icon" type="image/png" href={favicon} sizes="16x16" />
</Helmet>

This error occurs after a (short) while: nfl/react-helmet#373

Temporary workaround is to use the following until Helmet@6.0.0 stable is released:

<Helmet
    defaultTitle="React SSR Starter – TypeScript Edition"
    titleTemplate="%s – React SSR Starter – TypeScript Edition"
    link={[{ rel: 'icon', type: 'image/png', href: favicon }]}
/>
@TomWebbio
Copy link

Yeah man, it took me like 4 hours to find the fact that this is the issue after implementing hooks.

I converted the place where I add Helmet to a Class component for now to fix it! Hope they do an official release of version 6 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants