Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended quote and double quote functionality #2133

Open
2 of 8 tasks
anStalf opened this issue May 4, 2024 · 1 comment
Open
2 of 8 tasks

Extended quote and double quote functionality #2133

anStalf opened this issue May 4, 2024 · 1 comment
Assignees

Comments

@anStalf
Copy link

anStalf commented May 4, 2024

Proposal:

When you use SQL mode in Manticore, single quotes are used to write string data, which are used when writing phrases "Isn't, Let's", etc. in such cases, backslash escaping is used. In classic SQL, there is a lifehack that consists in using double quotes to frame a string and it is often used in processing forum messages or something similar.
An example of how it works now in Manticore:
INSERT INTO demo (info) VALUES ('Isn't it.');

An example of how it works in SQL:
INSERT INTO demo (info) VALUES ("Isn't it.");
At the same time, the solution works in the opposite direction:
INSERT INTO demo (info) VALUES (' Hey, where is this "thing"?');

Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Task estimated
  • Specification created, reviewed and approved
  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation proofread
  • Changelog updated
  • OpenAPI YAML updated and issue created to rebuild clients
@sanikolaev
Copy link
Collaborator

Supporting double quotes for inserts is not a big deal (probably just a one-line change). Supporting it in other cases (e.g. where match and string comparison) requires more work and better thinking.

We need to decide whether we want to support double quotes only for INSERTs/REPLACEs (may make users confused.) or everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants