Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change to v2 #64

Closed
wants to merge 1 commit into from
Closed

change to v2 #64

wants to merge 1 commit into from

Conversation

nilshah98
Copy link

Description of new feature, or changes

  • Currently, all the features from v1 migrated to v2.
  • There are a few restrictions in the migrated version v2, while searching for fixtures and scores, it's only limited till 10 days.
  • LeagueID needs to be specified to extend filter for more than 10 days.

ToDo

  • Migrate fictures and scores, to matches URI
  • Make league codes mandatory for scores and fixtures, for extending search day limit.

Related Issues and Discussions

Fixes #45

People to notify

@manrajgrover

@nilshah98
Copy link
Author

Here are the screen captures for the same -

  • football standings -l PL
    y0rfxdaaq0
  • football fixtures -l PL -d 5
    y5qivemwnv
  • No live matches right now, will update recording with scores soon.

@manrajgrover manrajgrover self-requested a review January 1, 2019 19:54
manrajgrover
manrajgrover reviewed Jan 1, 2019
View reviewed changes
config.json Outdated
@@ -1,3 +1,3 @@
{
"API_KEY": ""
}
"API_KEY": "8e6f6608e3154b1a956193827cdaec4c"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to change this now that it is in the public domain. Also, please be careful and not push keys to Github.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed it.

Also, I am getting a lot of linting errors, any idea how to resolve those?
Currently using VS Code, on Windows 10.

@manrajgrover
Copy link
Owner

@Freelancer-98 It should be easy to configure VSCode. We already have .vscode settings defined. Please install prettier and eslint VSCode plugin.

@manrajgrover
Copy link
Owner

@Freelancer-98 Also, please elaborate on features migrated. Thanks for working on this one! 😄

@nilshah98
Copy link
Author

@Freelancer-98 Also, please elaborate on features migrated. Thanks for working on this one! 😄

All of the features mentioned in the readme have been migrated, except for the limitations on the number of days for fixtures and scores, which is 10 days, at the moment.
Will try to work on it, as and when time permits.

Was a pleasure, to work with the football-cli.

@nilshah98
Copy link
Author

@Freelancer-98 It should be easy to configure VSCode. We already have .vscode settings defined. Please install prettier and eslint VSCode plugin.

Cool, will look into this soon.

@nilshah98 nilshah98 closed this Jun 11, 2019
@nilshah98 nilshah98 reopened this Jun 11, 2019
@nilshah98 nilshah98 closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manrajgrover manrajgrover manrajgrover left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate project to V2 API
2 participants
@nilshah98 @manrajgrover