Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Supporting waste collection between specific times that can span multiple days #2076

Open
tjmv opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request (excluding source request)

Comments

@tjmv
Copy link

tjmv commented May 10, 2024

I propose a feature for:

The integration in general

Describe your wanted feature

This component has been working great for normal waste collections, but it's basically useless for one particular type of waste that works different from the rest. Instead of being collected, we have to bring the waste to a specific spot quite far from my house and between specific hours. This is an exception even in the waste calendar made available by the provider where they simply put the available hours in the description.

Normally waste is collected early in the morning, so the default 10AM refresh fine works for this. But for this type you can drop it off from noon to the afternoon on the next day. Using the regular settings this means that it disappears before it has even started. Moreover, I prefer to bring it in the morning of the next day to avoid having to go in the dark. Even a simple offset would not would not work very well, because sometimes I have no choice but to bring it in on the evening of the same day. Right now I cannot use this component for the type of trash because most often it is already gone from the calendar when I want to check for it. (Another idea here: keep the previous event of each type available in the calendar)

The issue is somewhat similar to #679 , but those are fixed hours and not exactly what I would prefer. Ideally I can configure a start time and a total duration that can span multiple days. I would not mind making a pull request or even modifying the aforementioned one, but first I'd like some feedback. I want a proper solution that can be merged so I can simply update the component instead of having to use a personal fork.

@tjmv tjmv added the enhancement New feature or request (excluding source request) label May 10, 2024
@5ila5
Copy link
Collaborator

5ila5 commented May 11, 2024

The current implementation uses Date objects not DateTime object for every internal handling. I think Dates should keep the default behavior, maybe there could be a configuration option to use some kind of DateTime range, if the Source supports this: The source may return some kind of DateTime range instead of Date events and if this option is enabled the calendar shows this range.

This implementation probably needs some bigger changes and @mampfes should probably take a look first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (excluding source request)
Projects
None yet
Development

No branches or pull requests

2 participants