Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: day_switch_time does not seem to be working correctly #2067

Closed
5 of 7 tasks
Jaykurb opened this issue May 8, 2024 · 2 comments · Fixed by #2099
Closed
5 of 7 tasks

[Bug]: day_switch_time does not seem to be working correctly #2067

Jaykurb opened this issue May 8, 2024 · 2 comments · Fixed by #2099

Comments

@Jaykurb
Copy link

Jaykurb commented May 8, 2024

I Have A Problem With:

The integration in general

What's Your Problem

I have day switch time set to 20:00 but the day switches at 01:19

Screenshot 2024-05-08 at 07 24 31

config:

waste_collection_schedule:
  sources:
    - name: maldon_gov_uk
      args:
        uprn: "uprn"
      customize:
        - type: Refuse Collection
        - type: Recycling
  day_switch_time: "20:00"
  fetch_time: 01:00

Source (if relevant)

Maldon District Council / maldon.gov.uk

Logs

No response

Relevant Configuration

waste_collection_schedule:
  sources:
    - name: maldon_gov_uk
      args:
        uprn: "uprn"
      customize:
        - type: Refuse Collection
        - type: Recycling
  day_switch_time: "20:00"
  fetch_time: 01:00

Checklist Source Error

  • Use the example parameters for your source (often available in the documentation) (don't forget to restart Home Assistant after changing the configuration)
  • Checked that the website of your service provider is still working
  • Tested my attributes on the service provider website (if possible)
  • I have tested with the latest version of the integration (master) (for HACS in the 3 dot menu of the integration click on "Redownload" and choose master as version)

Checklist Sensor Error

  • Checked in the Home Assistant Calendar tab if the event names match the types names (if types argument is used)

Required

  • I have searched past (closed AND opened) issues to see if this bug has already been reported, and it hasn't been.
  • I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.
@Jaykurb
Copy link
Author

Jaykurb commented May 8, 2024

It seems like a similar issue to bristol_gov_uk which was raised in issue #1173 and resolved here. Unsure how to make these changes to maldon_gov_uk, though.

@5ila5
Copy link
Collaborator

5ila5 commented May 20, 2024

This probably happens because the site lists the collections of the current date as 'Last Collection' which is not parsed by the source (not confirmed), so the integration does not find the collection date on parse (~1:00 AM)
#2099 should fix this as it also parses the 'Last Collection'.

A fast workaround would be to set the fetch_time to 20:00 (note random_fetch_time_offset defaults to 60 minutes)

This will be part of release 1.49.0 or is available now as master (git) version (3-dot menu -> redownload -> change version to master -> fully restart HA (this will increase update cycle by a lot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants