New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify response types to intersection #445
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating package name
exports loglevel
fixes missing error code
this emits a warning from ava@typescipt which can be safely ignored
This reverts commit 1528de7.
This adds a warning in npm install for ava@typescript that can be safely ignored
lower node engine to >=12
Co-authored-by: Ryan Hart <ryan@makenotion.com>
Error Handling example uses `notion` variable without instantiating it first. Co-authored-by: Julie <julie@makenotion.com> Co-authored-by: Ryan Hart <ryan@makenotion.com>
Co-authored-by: Ryan Hart <ryan@makenotion.com>
…makenotion#394) * add instruction for giving integration access to database * update notion-github-sync with integration access instructions
* add block text example * clean up comments * add embed option * update comment: * pr feeedback: name change, updated switch case, join richtext array without comma * use iteratePaginatedAPI helper to capture all blocks on page
* Wiki related changes * Remove oauth related endpoints
…with toggleable heading type (makenotion#438)
* add fullstack webform example app * update package.json detail * make linter happy * delete old folder (name change * Update examples/web-form-with-express/public/client.js Co-authored-by: Ron Yehoshua <ron@makenotion.com> * update var naming for improved readbility * add console back to match appendApiResponse() --------- Co-authored-by: Ron Yehoshua <ron@makenotion.com>
Unfortunately we had to remove an old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Response types are currently in a union, the users cannot access response objects' property directly.
Example:
Fix
Current:
notion-sdk-js/src/api-endpoints.ts
Lines 10279 to 10286 in 83ac043
Fix:
Fixes #425 (comment) #443