Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The added IK Rig exponentially increases in size if you + - + - + the IK rig button #92

Open
Hunanbean opened this issue Jan 3, 2021 · 6 comments
Assignees

Comments

@Hunanbean
Copy link

Steps:
Import a model with skeleton (i used default no toes)
Press the IK Rig + button
ScreenShot14

Press the IK Rig - button
it is removed

Press the IK Rig + button again
ScreenShot15

Press the IK Rig - button
it is removed

Press the IK Rig + button again
ScreenShot16

Thank you for your continuing work

@joepal1976 joepal1976 self-assigned this Jan 4, 2021
@joepal1976 joepal1976 added the bug label Jan 4, 2021
@joepal1976
Copy link
Contributor

Well that certainly doesn't look optimal. :-)

@Palmer-JC
Copy link
Collaborator

Palmer-JC commented Jan 5, 2021 via email

@Hunanbean
Copy link
Author

Hunanbean commented Jan 5, 2021 via email

@Aranuvir
Copy link
Collaborator

Aranuvir commented Jan 9, 2021

The function does not set the size, but rather scales. Multiple scales are cumulative.

This absolutely does not make any sense. Adding and removing an ik-rig should not change scales, size or anything similar. That's definitely a bug in an urgent need to be fixed.
To be honest the rigging stuff is one of the main reasons why I'm still using mhx...

@Palmer-JC
Copy link
Collaborator

This just something mostly cosmetic in the viewport display called bbone
bbone

Other types are octahedral, stick, envelope, & wire.. The load code sets it to stick or wire. Why I decided to change to this is the bones you grab surround other bones, using bbone allows the size of the display of the bones to change on a bone-by-bone basis.

To do it by UI, goto Pose mode, select bones, and scale BBone. There is not an actual api call, but one of those Blender ops macro types
BonescalePNG

The code in ikrig.py is:

# make all regular bone slightly smaller, so IK's fit around
unitMult = 0.1 * self.rigInfo.unitMultplierToExported()
val = 0.6 * unitMult
bpy.ops.transform.transform(mode='BONE_SIZE', value=(val, val, val, 0))

As I said earlier, mine go progressively smaller not larger. I export in meters. Have not played with this since 2.79, other than to make sure it ran in 2.80. Back then, I also tried to reverse it when removing IK, so that if you turned it back on you would get the same result, but did not take.

You can always adjust it down yourself, but that is somehow not an absolute number, or it would always be the same no matter how many times it was done.

@Hunanbean
Copy link
Author

Hunanbean commented Jan 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants