Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CookieStore SameSite warning in Firefox #2735

Open
eelke opened this issue Feb 15, 2024 · 0 comments
Open

CookieStore SameSite warning in Firefox #2735

eelke opened this issue Feb 15, 2024 · 0 comments

Comments

@eelke
Copy link

eelke commented Feb 15, 2024

I have a project, using ember-simple-auth 6.0.0, and ember 5.3.

My application session store is very basic:

import CookieStore from 'ember-simple-auth/session-stores/cookie';

export default class ApplicationSessionStore extends CookieStore {
  sameSite = 'Strict';
}

This seems to work fine, however (only) in Firefox I see the following warning:

Cookie “ember_simple_auth-session-expiration_time” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite chunk.vendors-node_modules_formatjs_intl_lib_index_js-node_modules_clipboard_dist_clipboard_js-node-736ba6.7f8bb27ee02b0ae8b916.js line 358 > eval:16:3765

And the weird thing here is: the ember_simple_auth-session-expiration_time cookie has not even been set yet at this point.
Only ember_simple_auth-session-session exists and is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant