Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacking-tokens-cause-empty-spaces-fix #12248

Merged
merged 1 commit into from
May 18, 2024

Conversation

grimreap124
Copy link
Contributor

@grimreap124 grimreap124 commented May 15, 2024

Won't stack attached permanents creating empty spaces and only checks creatures summoning sickness when stacking.

image

Fixes #12246

@JayDi85
Copy link
Member

JayDi85 commented May 15, 2024

Is it fix all bugs from #12246?

@grimreap124 grimreap124 changed the title stacking-tokens-cause-empty-spaces stacking-tokens-cause-empty-spaces-fix May 15, 2024
@grimreap124
Copy link
Contributor Author

Yes I believe so. It's because I was also processing attached items with the new stack code when I should filter them out and leave it for the old code

@grimreap124
Copy link
Contributor Author

maybe @PurpleCrowbar could test as well to confirm its working as intended?

@grimreap124
Copy link
Contributor Author

PurpleCrowbar won't be able to test for a few days but I'm confident this is the fix

@PurpleCrowbar
Copy link
Member

Been testing with this, it seems to fix a lot of the problems. Just wondering, is it intentional that creature tokens no longer stack under any circumstances? Regardless, this should almost definitely be merged before the next beta update as it fixes critical issues

@JayDi85 JayDi85 merged commit 61b7918 into magefree:master May 18, 2024
2 checks passed
@JayDi85
Copy link
Member

JayDi85 commented May 18, 2024

is it intentional that creature tokens no longer stack under any circumstances

Yes, it was a more complex feature (required PT compare as example). Will be part of another PR.

@grimreap124
Copy link
Contributor Author

I have a branch ready to go that stacks creature tokens. I'll create a PR for it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to permanent stacking cause bugs in permanent layout
3 participants