Emrakul, the Promised End's Mindslaver effect has issues passing priority

[stevedavidmusic]

The Mindslaver effect of Emrakul, the Promised End (and probably Mindlsaver in general) seems very bugged when it comes to passing priority. The only way to move forward with priority seems to be if both players constantly turn their skips on and off. We experienced this in more than one match and I just replicated it myself on my machine just to see it going on from both sides. Normally I'd post screenshots for proof, but it's not exactly going to do much in this scenario.

It'll also randomly say that you lost control of the opponent's turn, although I'm not sure if you actually do lose control of their turn.

[Susucre]

Can confirm I've replicated the issue with [[Mindslaver]].
Not sure what is wrong and when that broke, but the "take control of player" effect still seems to have the original turn's player in control somewhat.

[github-actions]

Mindslaver - (Gatherer) (Scryfall) (EDHREC)

{6}
Legendary Artifact
{4}, {T}, Sacrifice Mindslaver: You control target player during that player's next turn. (You see all cards that player could see and make all decisions for the player.)

[JayDi85]

Can be related to player skip settings (e.g. game use it from wrong player). There few places in HumanPlayer with potentially wrong usages (I added related todo comments to it some time ago).

[Susucre]

I have looked at the PlayerImpl part and nothing felt out of place (stuff could be simplified, but the logic felt sane). But indeed that big method with a lot of TODO in HumanPlayer could have the root cause in its logic (it is long and convoluted, but so central a change on it should be carefully tested)

[alexander-novo]

I ran into a similar issue with [[Cruel Entertainment]] the other day - iirc, what had to happen was that the controlling player had to click the "switch hands" button every time priority was passed to pass priority for themselves and the player they were controlling.

[github-actions]

Cruel Entertainment - (Gatherer) (Scryfall) (EDHREC)

{6}{B}
Sorcery
Choose target player and another target player. The first player controls the second player during the second player's next turn, and the second player controls the first player during the first player's next turn.