Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull back saved runtime variables on trigger edit page #5047

Open
sugimiyanto opened this issue May 9, 2024 · 4 comments
Open

Pull back saved runtime variables on trigger edit page #5047

sugimiyanto opened this issue May 9, 2024 · 4 comments
Assignees
Labels
enhancement Polish or UX improvements

Comments

@sugimiyanto
Copy link

sugimiyanto commented May 9, 2024

Is your feature request related to a problem? Please describe.
It's tedious to re-enter runtime variables every time I need to edit a trigger. The previously saved runtime variables are not pulled back on the trigger edit page. I can imagine if I have tens of them.

Describe the solution you'd like
The previous saved runtime variables are pulled back on the trigger edit page.

Describe alternatives you've considered
Manually re-enter all the necessary runtime variables.

Additional context
The previous saved runtime variables:
saved runtime variable on a trigger (1)

Runtime variables on trigger edit page are empty.
saved runtime variables not shown on edit page (1)

@johnson-mage johnson-mage self-assigned this May 9, 2024
@johnson-mage johnson-mage added the enhancement Polish or UX improvements label May 9, 2024
@johnson-mage
Copy link
Member

@sugimiyanto Did you try adding "global variables" in the Pipeline Editor? Those should appear in the "Runtime variables" section when editing a trigger. If your runtime variables (e.g. target_table) were added in the Trigger Edit view at the time you created the trigger and not as a "global" variable, it may not appear under the Runtime variables section when editing the trigger again.
image

@johnson-mage
Copy link
Member

@johnson-mage the "global variables" is constant for a pipeline, isn't it? My pipeline is a generic pipeline which is reusable by multiple triggers to execute different context. The context difference is described in Runtime Variables on each trigger. So, "global variables" is not applicable for this case.

Got it, thanks for clarifying. Will make note of this to improve the UX.

@sugimiyanto
Copy link
Author

@johnson-mage the "global variables" is constant for a pipeline, isn't it?
My pipeline is a generic pipeline which is reusable by multiple triggers to execute different context. The context difference is described in Runtime Variables on each trigger.
So, "global variables" is not applicable for this case.

@sugimiyanto
Copy link
Author

thanks @johnson-mage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
Development

No branches or pull requests

2 participants