Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient use of semicolons #103

Open
e-oj opened this issue Dec 27, 2018 · 1 comment
Open

Insufficient use of semicolons #103

e-oj opened this issue Dec 27, 2018 · 1 comment

Comments

@e-oj
Copy link

e-oj commented Dec 27, 2018

Thanks for creating vapor.js. It does everything I've ever wanted, and much more. We recently migrated our frontend to vapor and we were able to reduce our page load time by 36000%.

While we've achieved incredible results by vaporizing our codebase, I'm very concerned by the apparent lack of semicolons in the vapor.js source. The syntax is perfectly valid and the code is well written but according to the Airbnb style guide, missing semicolons could cause problems down the road. How do you plan to address this issue without jeopardizing the smallness or fastness of vapor.js?

@LiamTownsley
Copy link

The semicolons were removed for preformance time although you can a slower but more secure progam it's called semicolon.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants