-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making params optional broke examples #4
Comments
Applying the following patch (to undo the optional change) fixes the ERROR, but I do not know what the right generic solution with keywords arguments is:
|
The regression functions now accepts two keyword arguments: params and z. The optional argument z is an initial guess of the solution. Giving a good guess tends to improve convergence speed. |
My apologies, I should have explained better. When I run the unit tests I get:
Which means the current use of kwargs is broken after removing the params keyword from the method signature. I will find the culprit and submit a pull request. |
The problem is accessing params as a variable without getting it out from kwargs:
|
The main issue in our case, is that params.rho needs to be accessed to create the proxs but params is now optional. I have a crazy idea, what if we get rid of the params dict and just let keywords propagate? That will improve the syntax of the functions in regressions:
without a need for a hack like the one below:
|
Running the above file returns now:
The text was updated successfully, but these errors were encountered: