Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot configure images for channels with decimal points #13

Open
computmaxer opened this issue Sep 23, 2013 · 7 comments
Open

Cannot configure images for channels with decimal points #13

computmaxer opened this issue Sep 23, 2013 · 7 comments

Comments

@computmaxer
Copy link

Perhaps I am just using the toml syntax wrong, but when I set the image for a channel with a decimal place, like 5.1, I get this:

Failed to match sequence (ALL_SPACE (KEY_GROUP / KEY_VALUE / COMMENT_LINE){0, } ALL_SPACE) at line 10 char 1.
`- Don't know what to do with "5.1 = \"abc" at line 10 char 1.

config:

[channel_logos]
5.1 = "abc.png"
@maddox
Copy link
Owner

maddox commented Sep 23, 2013

Ahh, its probably a bug in toml. That's kinda tricky. Try quoting the key "5.1" and see if that works.

@computmaxer
Copy link
Author

Hmm, nope. Same kind of error.

Failed to match sequence (ALL_SPACE (KEY_GROUP / KEY_VALUE / COMMENT_LINE){0, } ALL_SPACE) at line 10 char 1.
`- Don't know what to do with "\"5.1\" = \"a" at line 10 char 1.

That's too bad for toml. I may alter wallop a bit to read in channel image definitions from a different file type for my use, since all of my channels have decimal points at the moment.

@maddox
Copy link
Owner

maddox commented Sep 23, 2013

Sorry about this. This is very unfortunate. We can work on just using a new format inside the toml.

Feel free to submit a change.

On Sep 23, 2013, at 1:45 PM, Max Peterson notifications@github.com wrote:

Hmm, nope. Same kind of error.

Failed to match sequence (ALL_SPACE (KEY_GROUP / KEY_VALUE / COMMENT_LINE){0, } ALL_SPACE) at line 10 char 1.
`- Don't know what to do with ""5.1" = "a" at line 10 char 1.
That's too bad for toml. I may alter wallop a bit to read in channel image definitions from a different file type for my use, since all of my channels have decimal points at the moment.


Reply to this email directly or view it on GitHub.

@computmaxer
Copy link
Author

Here is a potential fix: computmaxer@940574a

I defined the channel logos like this:

5_1 = "abc.png"
8_1 = "cbs.png"
13_1 = "nbc.png"
17_1 = "fox.png"

and then simply used a string substitution before checking the config for the channel number.

I'm not in love with this solution but it is easy and it works. If you think it is okay I'll make a pull request!

@maddox
Copy link
Owner

maddox commented Sep 24, 2013

wow, gross, hahah. Sit on it for a while, at least you have it working for yourself. that's not very clear in my opinion. I'll see if i can come up with something.

@computmaxer
Copy link
Author

Yeah I definitely agree. I'll also try to think of other solutions. I tried starting each line with a letter, like channel_5.1 but it still chokes on the decimal point.

@JerseyDevil6
Copy link

Any real solution for this one yet? All of my channels have decimal points too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants