Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthToken is insecure. #6

Open
cagerton opened this issue Dec 11, 2013 · 1 comment
Open

AuthToken is insecure. #6

cagerton opened this issue Dec 11, 2013 · 1 comment

Comments

@cagerton
Copy link

I was just glancing through your code and I noticed that your Gateway AuthToken class uses a uuid3 (configured with a DNS namespace) of a timestamp. It doesn't look like it's used anywhere, but I have to warn you that this will not produce a cryptographically secure value.

I'd like to encourage you to use an HMAC based token signature using a configurable application secret. This is how Django does it (link to Signer) and Tornado (link to create_signed_value) do it.

@cmdelatorre
Copy link
Contributor

cagerton, thank you very much for pointing it. We will address this issue as soon as possible. Furthermore, a pull-request is welcome ;-)

Seriously, thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants