Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix definition of ndarray.itemset #5

Open
dmoisset opened this issue Jul 26, 2016 · 3 comments
Open

fix definition of ndarray.itemset #5

dmoisset opened this issue Jul 26, 2016 · 3 comments

Comments

@dmoisset
Copy link
Contributor

The current definition should probably use ShapeType as an index, and _S as value. To avoid the ambiguity of the 1 argument/2 argument version, an @overload definition could be better.

@dmoisset
Copy link
Contributor Author

Also, I think itemset makes sense only on ndarray, not on any ArrayLike given that generic is immutable

@abarto-machinalis
Copy link

Although it doesn't make sense, itemset IS part of the generic interface. All it does it raise an exception, though.

@dmoisset
Copy link
Contributor Author

being in the interface but always failing is essentially indistinguishable in python to not being on the interface, so I think it's a good idea to catch this statically if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants