Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port numpy-mymy upstream into NumPy? #16

Open
shoyer opened this issue Mar 15, 2017 · 4 comments
Open

Port numpy-mymy upstream into NumPy? #16

shoyer opened this issue Mar 15, 2017 · 4 comments

Comments

@shoyer
Copy link

shoyer commented Mar 15, 2017

As a NumPy developer and user, I would love to see this happen. I can't promise I'll have the time to make this happen on my own, but I certainly am willing to help anyone with questions about the process.

Step 1 would be to add a license to this repository, preferably 3-clause BSD like NumPy.

@dmoisset
Copy link
Contributor

Hi Stephan, It would be fantastic if this is found to be useful upstream and integrated. Some of the work done here was a bit halted due to some limitations on mypy that may have been fixed in recent releases (I haven't retried yet). Some aspects also can be reimplemented in a better way once the protocol feature (currently in design by the mypy team to be presented as a PEP) is ready (and these changes would be "API-breaking" for people using these), so it might be worth waiting a bit.

Other than that, what do you thing would be needed to push this into numpy upstream?

The repo already has a 3-clause BSD in the master branch.

@shoyer
Copy link
Author

shoyer commented Mar 22, 2017

Oops, not sure how I missed the license! Yes, that should already cover it.

You raise a good point about making further improvements. So perhaps it is indeed worth waiting a while before integrating these into NumPy proper, at least as anything other than provisional. Protocols will indeed make a big difference for NumPy.

Let me know if you think it would help to move this repository to any of (1) numpy github account, (2) typeshed or (3) numpy proper.

@ErikBjare
Copy link

Related issue: #19

@shoyer
Copy link
Author

shoyer commented Dec 28, 2018

We’ve started over with stubs in the https://github.com/numpy/numpy-stubs repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants