You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The manual chapter Developing a Network Device Support Package should probably hint the user to implement a ping() method to avoid the controllers being restarted by the ctlmgr.
Futhermore, a log entry like WARNING:ctlmgr(artiq-host):artiq_comtools.ctlmgr:Controller xyz ping failed is misleading to an unsuspecting user as it leaves the impression that the controller is hung, where it in fact very much alive but failed to implement the ping() method. It would be nice to make the message explicit if the controller did not find the method in the first place.
The text was updated successfully, but these errors were encountered:
We could just add an explanatory paranthetical to the error message, something like (controller dead, or ping(), which should return True, not implemented).
Mentioning this in the manual would of course also help.
@evilmav: Do you want to open a PR improving the wording?
The manual chapter Developing a Network Device Support Package should probably hint the user to implement a
ping()
method to avoid the controllers being restarted by thectlmgr
.Futhermore, a log entry like
WARNING:ctlmgr(artiq-host):artiq_comtools.ctlmgr:Controller xyz ping failed
is misleading to an unsuspecting user as it leaves the impression that the controller is hung, where it in fact very much alive but failed to implement the ping() method. It would be nice to make the message explicit if the controller did not find the method in the first place.The text was updated successfully, but these errors were encountered: