meson: fix build on NixOS #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this may have broken the other builds. :/ |
|
Even with this patch it's still failing when using tool-muticall (which is my preference since I understand it reduces the output size) |
|
This does succeed without tool-multicall in a nix build. Looking at the output it's only 6.9MB, so if we need to build with separate binaries I'm fine with that. |
no, I have a plan to fix and cover all cases, no doubt :-) |
Fixes: lxc#4427 Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
mihalicyn
force-pushed
the
new_meson_build_fixup
branch
from
ec948ad
to
4be1c12
Compare
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
|
Testsuite passed |
1 similar comment
|
Testsuite passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported recently that on NixOS LXC fails to build with the following errors:
at the same time everything works just fine on Ubuntu 20/22.
Let's workaround this for now by using
link_wholeinstead oflink_with, which means that we are explicitly asking all symbols to be linked (independent from if they are used or not). It's not a big deal, as this two binaries are big anyways. It's in my TODO to refactor all this build mess, but it's just too hard to make it at once and it requires a lot of changes and code reshuffling.It's still interesting what's the difference between NixOS and Ubuntu in that regard. From what I found during debugging is that meson on NixOS (version 1.3.2) generates dependency files differently from how meason on Ubuntu does (version 0.61.2). Likely there is a problem, but it's a matter of further investigation.
Fixes: #4427