rtw89_8852ce: probe of 0001:03:00.0 failed with error -22

[razvanphp]

Not sure if related with the other issues added lately, but latest master failed today on a system that was working fine with a version from a few weeks ago (can't know for sure since I formatted the drive). No hardware changes.

Ubuntu 20.04.6 LTS (GNU/Linux 5.10.120-tegra aarch64)

$ sudo dmesg |grep rtw89
[   12.524217] rtw89_8852ce 0001:03:00.0: Adding to iommu group 7
[   12.532820] rtw89_8852ce 0001:03:00.0: loaded firmware rtw89/rtw8852c_fw.bin
[   12.540450] rtw89_8852ce 0001:03:00.0: enabling device (0000 -> 0003)
[   12.548803] rtw89_8852ce 0001:03:00.0: Firmware version 0.27.56.14 (1942d927), cmd version 0, type 1
[   12.558231] rtw89_8852ce 0001:03:00.0: Firmware version 0.27.56.14 (1942d927), cmd version 0, type 3
[   12.833760] rtw89_8852ce 0001:03:00.0: chip rfe_type is 1
[   12.876162] Modules linked in: ip6table_filter ip6_tables xt_conntrack iptable_filter xt_MASQUERADE xt_nat xt_addrtype iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 libcrc32c rtw_8852ce(OE+) rtw_8852c(OE) rtw89pci(OE) rtw89core(OE) mac80211 aes_ce_blk crypto_simd cryptd aes_ce_cipher ghash_ce input_leds sha2_ce btusb sha256_arm64 sha1_ce btrtl nvgpu btbcm cfg80211 btintel pwm_fan nct1008 tegra_bpmp_thermal ina3221 r8168 nv_imx464 max96793 max96792 spi_tegra114 nvidia(OE) binfmt_misc nvmap ip_tables x_tables
[   12.876339]  rtw89_core_register+0x1f0/0x5e8 [rtw89core]
[   12.876344]  rtw89_pci_probe+0x6f8/0xa88 [rtw89pci]
[   12.876377]  rtw89_8852ce_driver_init+0x30/0x1000 [rtw_8852ce]
[   12.884231] rtw89_8852ce 0001:03:00.0: failed to register hw
[   12.892590] rtw89_8852ce 0001:03:00.0: failed to register core hw
[   12.898877] rtw89_8852ce 0001:03:00.0: failed to register core
[   12.944661] rtw89_8852ce: probe of 0001:03:00.0 failed with error -22

Way to reproduce:

git clone https://github.com/lwfinger/rtw89.git
cd rtw89
make
sudo make install
cd /lib/firmware/rtw89/
sudo sudo wget https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/plain/rtw89/rtw8852c_fw.bin
sudo sudo wget https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/plain/rtw89/rtw8852b_fw.bin
sudo sudo wget https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/plain/rtw89/rtw8852b_fw-1.bin

$ lspci |grep Realtek
0001:03:00.0 Network controller: Realtek Semiconductor Co., Ltd. Device c852 (rev 01)
0008:01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 15)

Any hint? Thank you!

[lwfinger]

There is a problem with Ubuntu 20.04 that I have not yet found a fix. As a workaround, in the rtw89 folder use terminal input 'git checkout 6dc944', then 'make' and 'sudo make install'. That will get you a version that works.

[razvanphp]

Ok, thanks for the heads up, hope my findings help you narrow down the problem:

1. tried 6dc9441 and I got this compile error:

/home/jetson/rtw89/debug.c: In function ‘rtw89_debug_priv_txpwr_table_get’:
/home/jetson/rtw89/debug.c:846:2: error: implicit declaration of function ‘rtw89_print_tas’ [-Werror=implicit-function-declaration]
  846 |  rtw89_print_tas(m, rtwdev);
      |  ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:281: /home/jetson/rtw89/debug.o] Error 1
make[1]: *** [Makefile:1854: /home/jetson/rtw89] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.10.120-tegra-ubuntu20.04_aarch64/kernel-5.10'
make: *** [Makefile:93: all] Error 2

2. then tried e39dd3b and it compiled, but same error like in OP.
3. then tried ebe87ac and it worked:

$ sudo dmesg -T |grep rtw89
[Wed May  1 07:02:30 2024] rtw89_8852ce 0001:03:00.0: Adding to iommu group 7
[Wed May  1 07:02:30 2024] rtw89_8852ce 0001:03:00.0: loaded firmware rtw89/rtw8852c_fw.bin
[Wed May  1 07:02:30 2024] rtw89_8852ce 0001:03:00.0: enabling device (0000 -> 0003)
[Wed May  1 07:02:30 2024] rtw89_8852ce 0001:03:00.0: Firmware version 0.27.56.14 (1942d927), cmd version 0, type 1
[Wed May  1 07:02:30 2024] rtw89_8852ce 0001:03:00.0: Firmware version 0.27.56.14 (1942d927), cmd version 0, type 3
[Wed May  1 07:02:30 2024] rtw89_8852ce 0001:03:00.0: chip rfe_type is 1