Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in core.c #279

Open
Sauerlandlinux opened this issue Nov 5, 2023 · 2 comments
Open

Typo in core.c #279

Sauerlandlinux opened this issue Nov 5, 2023 · 2 comments

Comments

@Sauerlandlinux
Copy link

Building in openSUSE as rpm, typo in line 3909

[ 62s] /home/abuild/rpmbuild/BUILD/rtw89-5.1762.gbb980e8/obj/default/core.c: In function 'rtw89_init_he_cap':
[ 62s] /home/abuild/rpmbuild/BUILD/rtw89-5.17
62.gbb980e8/obj/default/core.c:3909:7: error: 'IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_16US' undeclared (first use in this function); did you mean 'IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US'?
[ 62s] IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_16US;
[ 62s] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 62s] IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US
[ 62s] /home/abuild/rpmbuild/BUILD/rtw89-5.17~62.gbb980e8/obj/default/core.c:3909:7: note: each undeclared identifier is reported only once for each function it appears in

@Sauerlandlinux
Copy link
Author

Sauerlandlinux commented Nov 5, 2023

Here is a patch:

diff -U 3 -H -d -r -N -- a/core.c b/core.c
--- a/core.c	2023-11-05 16:42:38.331156134 +0100
+++ b/core.c	2023-11-05 17:22:26.055370953 +0100
@@ -3906,7 +3906,7 @@
 				  IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_COMP_SIGB |
 				  IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_NON_COMP_SIGB |
 #if LINUX_VERSION_CODE < KERNEL_VERSION(5, 17, 0)
-				  IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_16US;
+				  IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US;
 #else
 				  u8_encode_bits(IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US,
 						 IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_MASK);
diff -U 3 -H -d -r -N -- a/fw.c b/fw.c
--- a/fw.c	2023-11-03 17:09:04.222008548 +0100
+++ b/fw.c	2023-11-05 17:21:53.819638113 +0100
@@ -1865,7 +1865,7 @@
 		u8 pad;
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(5, 17, 0)
-		pad = FIELD_GET(IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_MASK,
+		pad = FIELD_GET(IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_MASK,
 #else
 		pad = FIELD_GET(IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_MASK,
 #endif

@Sauerlandlinux
Copy link
Author

It was an error with the backported Kernel from openSUSE, all builds fine.

So close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant