Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code-splitting #3

Open
lvnam96 opened this issue May 13, 2019 · 1 comment
Open

Code-splitting #3

lvnam96 opened this issue May 13, 2019 · 1 comment
Assignees
@lvnam96
Labels
help wanted Extra attention is needed optimization Optimizing code
Projects
The first stable release v1.0.0
Milestone
First workable st...

Comments

@lvnam96
Copy link
Owner

lvnam96 commented May 13, 2019

Tutorials

Initial unnecessary code:

  • Contact Card
  • Edit Contact Form
  • Settings page (in v2.0)
@lvnam96 lvnam96 self-assigned this May 13, 2019
@lvnam96 lvnam96 added help wanted Extra attention is needed in progress This task is on progress optimization Optimizing code labels May 13, 2019
@lvnam96 lvnam96 added this to the Next stable version v2.0.0 milestone May 13, 2019
@lvnam96
Copy link
Owner Author

lvnam96 commented May 13, 2019 •
edited

After installed @babel/plugin-syntax-dynamic-import, webpack compilation failed:

Module parse failed: Unexpected token (xx:xx)
You may need an appropriate loader to handle this file type.

More info: webpack/webpack#8656
Follow the link above for a workaround.

@lvnam96 lvnam96 mentioned this issue May 14, 2019
Open
lvnam96 added a commit that referenced this issue May 14, 2019
@lvnam96
Implement React code-splitting:
6d0e20a 
- Issue #3
- Install a babel plugin to allow parsing `import()`
- Fix #4
- Create component LoadingPopup
- Introduce code-splitting when open ContactCard or EditContactForm
@lvnam96 lvnam96 added this to To do in The first stable release v1.0.0 via automation May 17, 2019
@lvnam96 lvnam96 removed the in progress This task is on progress label May 17, 2019
@lvnam96 lvnam96 moved this from To do to Done in The first stable release v1.0.0 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvnam96 lvnam96

Labels
help wanted Extra attention is needed optimization Optimizing code
Projects
No open projects
The first stable release v1.0.0
  
Done
Milestone
First workable stable version
Development

No branches or pull requests
1 participant
@lvnam96