Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 critical but easy to fix integer overflows #143

Open
dns43 opened this issue Jan 31, 2021 · 0 comments
Open

2 critical but easy to fix integer overflows #143

dns43 opened this issue Jan 31, 2021 · 0 comments

Comments

@dns43
Copy link

dns43 commented Jan 31, 2021

decodeGeneric() in lodepng.c:4812 has integer overflow.
lodepng_inspect_chunk() in lodepng.c:4716 has integer overflow.

Can be fixed easily by adding check if INT_MAX-chunkLength-12 < chunk, or using static int lodepng_addofl(size_t a, size_t b, size_t* result) in lodepng.cpp

Happy to provide PoC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant