Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua 5.4 #497

Closed
SinisterRectus opened this issue May 12, 2020 · 7 comments
Closed

Lua 5.4 #497

SinisterRectus opened this issue May 12, 2020 · 7 comments
Labels
build platform

Comments

@SinisterRectus
Copy link
Member

Lua 5.4.0 is nearing a final release. It is currently at rc3.

Our supported Lua versions according to our rockspec is lua >= 5.1. Does this imply that 5.4 is supported on release? If so, think we should should look at whether that is true. I'm not sure if there are any compatibility changes that will affect us.
@squeek502
Copy link
Member

Would definitely be nice to start testing 5.4 in CI.

@SinisterRectus SinisterRectus mentioned this issue Jul 2, 2020
Merged
@squeek502 squeek502 mentioned this issue Sep 5, 2020
Closed
@SinisterRectus
Copy link
Member Author

Lua 5.4 has formally released since opening this issue. https://www.lua.org/manual/5.4/readme.html

@squeek502 squeek502 mentioned this issue Sep 6, 2020
Merged
@squeek502 squeek502 mentioned this issue Oct 15, 2020
Open
@SinisterRectus
Copy link
Member Author

SinisterRectus commented Oct 18, 2020 •
edited

Looks like #515 is merged. Are the build issues fixed? Should we make a 1.40.0 release?

@zhaozg
Copy link
Member

zhaozg commented Oct 18, 2020

Looks like #515 is merged. Are the build issues fixed? Should we make a 1.40.0 release?

YES

@squeek502
Copy link
Member

I'd like to finish up #487 and merge it before releasing 1.40.0. Will try to do that soon.

@zhaozg
Copy link
Member

zhaozg commented Oct 22, 2020 •
edited

Anything need to do before a new release?

@SinisterRectus
Copy link
Member Author

There are some open issues. #503 / #505 / #506. Not sure how easy those are to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zhaozg @squeek502 @SinisterRectus