Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup tmp dirs in vulnerability upsert job #1032

Open
breadchris opened this issue Dec 7, 2022 · 0 comments
Open

cleanup tmp dirs in vulnerability upsert job #1032

breadchris opened this issue Dec 7, 2022 · 0 comments

Comments

@breadchris
Copy link
Contributor

breadchris commented Dec 7, 2022

The vulnerability upsert job is running out of disk space due to the job not properly cleaning up tmp dirs. Even with our best attempts at trying to make sure this is done correctly, it seems to still not be working:

yeah just call that function inside here https://github.com/lunasec-io/lunasec/blob/master/lunatrace/bsl/ingest-worker/cmd/ingestworker/vulnerability/vulnerability.go#L59

vulnerability.go
                        advisoryLocation := ctx.Args().First()
<https://github.com/lunasec-io/lunasec|lunasec-io/lunasec>lunasec-io/lunasec | Added by GitHub
white_check_mark
index
thinkies
12:37
as like defer util.RemoveCleanupDirs()
12:37
and we should be fine
12:37
it is a bit of a hack to make sure that all of your temporary resources are cleaned up no matter what happens to the application
12:38
oh weird i do have this run https://github.com/lunasec-io/lunasec/blob/master/lunatrace/bsl/ingest-worker/cmd/ingestworker/main.go#L52

main.go
        fx.Invoke(func() {
<https://github.com/lunasec-io/lunasec|lunasec-io/lunasec>lunasec-io/lunasec | Added by GitHub
12:38
but i guess it is not working?
12:39
i wrote this specifically so that no matter what happened to the application, it would clean up the directories
12:39
very strange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant