Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Question] Add builtin_standard for the minetest lua api #107

Open
BuckarooBanzay opened this issue Feb 5, 2024 · 1 comment · May be fixed by #108
Open

[Feature][Question] Add builtin_standard for the minetest lua api #107

BuckarooBanzay opened this issue Feb 5, 2024 · 1 comment · May be fixed by #108

Comments

@BuckarooBanzay
Copy link

I'd like to add a builtin_standard for the minetest lua api (see: https://github.com/minetest/minetest/blob/master/doc/lua_api.md)

Similar to: https://github.com/lunarmodules/luacheck/blob/master/src/luacheck/builtin_standards/love.lua

Give me a 👍 and i open a PR for it.
@alerque
Copy link
Member

alerque commented Feb 7, 2024 •
edited

Sure, this sounds reasonable. A quick review suggests there is a fairly established and document API and quite a few users.

The only catch will be that after you get a PR working to your satisfaction I'll want to see some testing. Since I don't have any involvement in minetest, one other party that actually uses minetest and can verify your PR would be useful, and/or you can setup CI checks on public code somewhere using GH actions so we can see it in action.

@BuckarooBanzay BuckarooBanzay linked a pull request Feb 8, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add minetest to builtin standards BuckarooBanzay/luacheck
2 participants
@alerque @BuckarooBanzay