Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send PR to PostCSS README #20

Closed
ai opened this issue Jul 18, 2015 · 6 comments
Closed

Send PR to PostCSS README #20

ai opened this issue Jul 18, 2015 · 6 comments

Comments

@ai
Copy link

ai commented Jul 18, 2015

You should add this awesome plugin to Plugins section in PostCSS README. Wait for your PR.

I think “Others” section will be best match.
@luisrudge
Copy link
Owner

We have some rough edges to fix yet, but I'll add this repo when we fix some conceptual issues

@ai
Copy link
Author

ai commented Sep 2, 2015

Ping :)

@luisrudge
Copy link
Owner

Pong! I discovered that most of the fixes can't be really fixed without more context about where the class is being used. See #9, #17 and #18.
Maybe I should just fix what can be fixed for sure, and go with that?

@ai
Copy link
Author

ai commented Sep 2, 2015

Warnings will be OK in this case.

But you definetly should send PR to PostCSS :)

@luisrudge
Copy link
Owner

Ok. Let me remove some danger-ish code and I'll submit the PR

@luisrudge
Copy link
Owner

Done! postcss/postcss#540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ai @luisrudge