New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove target_module LoRA mapping for Phi-2 model #3910

Open

arnavgarg1 opened this issue Jan 23, 2024 · 0 comments

Contributor

arnavgarg1 commented Jan 23, 2024

The current PEFT LoRA modules map to the wrong target modules for Phi-2 since the architecture was recently updated.

I created a PR on the PEFT repo to update this to new target modules: huggingface/peft#1375

For now, we will fall back to target_modules for Phi-2 that lead to good model performance.

arnavgarg1 mentioned this issue

Add default LoRA target modules for Phi-2 #3911

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment