Bypass button not working in Ardour

[davidhealey]

As the title. Pressing the bypass button or the enable button doesn't appear to do anything.

[lucianodato]

Ok will check asap

[davidhealey]

Any progress on this?

[nettings]

I can confirm this behaviour. Ardour's bypass button seems to control the "enable" switch in the plugin, which in turn doesn't do anything. I think (but I'm not sure) Ardour patches around a plugin to "bypass" it only if it doesn't see the plugin has such a feature, and tries to use the plugin's bypass feature if it does.
So I would suspect that the issue is not limited to Ardour.

A quick look at signal_crossfade_run tells me there seems to be a low-pass filtered dynamic wet/dry coefficient, but I don't quite understand the logic. The target is updated once per buffer, but shouldn't the dynamic coefficient be updated once every sample?
So I guess the line

self->wet_dry += self->tau * (self->wet_dry_target - self->wet_dry);

should go into the loop in signal_crossfade_run()...? Or am I being confused about how this is supposed to work?

[thomask-gh]

The issue is still there with Ardour 7.2.0 and Noise Repellent v0.2.3. I’m new to DAWs and I was first learning how Noise Repellent works and got very confused to hear no difference between having the plugin enabled or not, even when giving it extreme settings on purpose, only to find out there was a difference when I removed the plugin from my bus altogether. It made me suspect that the enable/bypass feature might be broken, and it indeed is.

It would be great if you could fix this, but thanks a lot for this plugin anyway!