Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Removing user handling #1516

Open
mohamedhoss123 opened this issue Mar 28, 2024 · 1 comment
Open

[Feature Request]: Removing user handling #1516

mohamedhoss123 opened this issue Mar 28, 2024 · 1 comment
Labels
feature request New feature requests

Comments

@mohamedhoss123
Copy link

Package

lucia

Description

From my understanding to source code of lucia uesr handling is used for checking if user exists in db if yes will return the properties we want else we will delete the session made that request , this aprouch have alot of cons :

  • make unnessesary query at most of the protected routes witch translated to un wanted delay
  • preventing us from making adapters for redis or any db that should only handle sessions without making our hands dirty with illegal workarounds and adapters 😂
  • make the idea of making guest session also need to have it's illegal adapter
  • what we are trying to achive is already beign achived by sql databases by making a onDelete:cascade for our relation
  • making building adapters harder as we will write more code
  • making more config and if I wanted to retrive spisific user data in a end point and other data on ther i have to make separate query or take all data in the config and retrive unnessesary data

I think we talked about this topic before on discord but as this topic apeared again and I didn't find a clear state saying what we are going to do about it so I wanted know .

@mohamedhoss123 mohamedhoss123 added the feature request New feature requests label Mar 28, 2024
@pilcrowOnPaper pilcrowOnPaper changed the title [Feature Request]: removing user handling from lucia in v4 [Feature Request]: Removing user handling May 1, 2024
@pilcrowOnPaper
Copy link
Member

I am open to the idea and slowly leaning towards it. Would have to be part of v4, which probably will be early next year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature requests
Projects
None yet
Development

No branches or pull requests

2 participants