Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project dead? #112

Open
2dpdlja496or43iq opened this issue Apr 23, 2023 · 10 comments
Open

Is this project dead? #112

2dpdlja496or43iq opened this issue Apr 23, 2023 · 10 comments

Comments

@asiekierka
Copy link

I recommend using the Insights -> Network tab to figure out which fork is most active.

My fork was initially created specifically for the OpenComputers project, and I have no plans on further maintenance beyond that.

@fabrice-ducos
Copy link

fabrice-ducos commented Apr 23, 2023

You can also use Insights -> Forks.

My fork was an attempt to upgrade the luaj project from old JDKs (1.2 - 1.4) to JDK 8+, and also with newer versions of ant (1.10+).

It was performed as a subproject of another personal project of mine, and it seems to work with newer JDKs (even 17) for JSE. I managed to run it successfully on Windows 10, Linux Ubuntu 22.04 and MacOSX Monterey 12.6.3.

However I wouldn't recommend it for production if it's what you have got in mind (at least not before thorough testing first).

The issue is that I am much less familiar with ant than with maven or gradle.

If your project includes deployment on mobiles, my fork is not for your use case. I am not familiar with the JME development and did not manage to compile it in this case (JME doesn't support many new language constructs, including generics). Therefore the JME part is not compiled by default in my fork (though the code is still there, and a compilation can still be attempted, with no guarantee, with ant all or ant jar-jme).

Best wishes

@wagyourtail
Copy link

I merged a few of the pr's here and use mine for https://github.com/jsmacros/jsmacros-lua im not exactly actively maintaining it, but if people were to send pr's I would read them over at some poimt

@fabrice-ducos
Copy link

Dear @wagyourtail,
I have sent a pull request from my fork, if you want to consider it, with a caveat regarding the drop of JME support.
I would have preferred to keep supporting JME, but JME seems to be legacy and maintaining it implies to be stuck to JDK 1.4

Best regards

@farmboy0
Copy link

I did extensive clean up and rework of luaj in my fork, common formatting, convert to maven, tests as junit5 as well as some bug fixes but Im not actively maintaining it. So while anyone is free to use my work I do not plan to go through the work again to make it match another fork.

@wagyourtail
Copy link

@fabrice-ducos part of my fork was merging @farmboy0 's fork, which converts to maven. iirc this includes java 8 update...
(yeah maybe need to do something if we want jme to actually work properly there still)

as well as

@fabrice-ducos
Copy link

Dear @farmboy0, @wagyourtail.
Thank you for these updates. I agree that it's the way to go.
Best regards.

@MINUTE1084
Copy link

Hi.

My project was created for the Spigot plugin for Minecraft.

It's a fix for some issues with the Spigot API integration, so there probably won't be any significant modifications for other projects.

It's not currently in development, so I don't think there will be any further research.

I apologize for the late response and thank you for your interest in the project.

@anthonywww
Copy link

Hi.

I'd recommend using @wagyourtail's fork (combined branch) as it seems to be the most mature?

Other fork details:

I noticed @lenrik1589's fork added Java 17 use of record and properly named the classes in core to PascalCase. According to their commit message they also are moving things away from reflections to lambdas.

lenrik1589@e4f13dd


Looks like @hashsploit's fork is no longer maintained, it appears the only changes was to remove JME support and add support for Java 1.8+ for use in Maven + JitPack.

https://github.com/hashsploit/clank/blob/feature/overhaul/build.gradle.kts#L64

I plan on using luaj in conjunction with LWJGL3 for scripting.

Thanks for keeping this project alive!

@lenrik1589
Copy link

I noticed @lenrik1589's fork added Java 17 use of record and properly named the classes in core to PascalCase. According to their commit message they also are moving things away from reflections to lambdas.

i am not sure i wish to continue working on the project, as i worked on it in conjunction with Kingdom-of-The-Moon/FiguraRewriteRewrite and (now inaccessible, likely private) Kingdom-of-The-Moon/luaj, which transitioned into FiguraMC/Figura and respectively FiguraMC/luaj but I have been removed from the team of people who work on it which made me lose all motivation to continue active work, i might keep working on it, but even slower than i did before…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants