Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider std::io::Stdin instead of File('/dev/stdin') #22

Open
bovee opened this issue Nov 18, 2023 · 1 comment
Open

Consider std::io::Stdin instead of File('/dev/stdin') #22

bovee opened this issue Nov 18, 2023 · 1 comment

Comments

@bovee
Copy link
Contributor

bovee commented Nov 18, 2023

I'm not sure if there's a performance difference (in which case please feel free to add a comment and disregard this), but I think opening /dev/stdin instead of using std::io::Stdin might limit the platforms fasten works on to only POSIX ones (i.e. probably not Windows). Not a high priority, but an easy search/change and probably a good beginner bug.

@lskatz
Copy link
Owner

lskatz commented Nov 27, 2023

Thank you for that tip! I am going to leave this ticket open for when I start refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants