New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zombie_killer not executing correctly #110
Comments
@grantwest I think you're probably not seeing any more output beyond that point because of mix-test.watch/priv/zombie_killer Lines 7 to 8 in cabcb68
If you uncomment that line and run it with I think that different versions of |
Commenting out the
Looks like the
The tests still aren't running though. I think it has something to do with the quoting of the args to the |
Doesn't work for me either. It works if I change the zombie killer script shell to bash. |
Why do we not use the script recommended by the standard library? https://hexdocs.pm/elixir/Port.html#module-zombie-operating-system-processes |
I initially tried adding that script in #106, but it didn't work for me. The version that I ended up adding here is the one that's in the Since this is just a copy of the script that exists in the Elixir lang repo, perhaps it would make more sense to open an issue and ask for help there? If we can make it more portable, we'd probably want that change to be made in the |
Perhaps a wider discussion would be beneficial. If this script does work for everyone I may revert to not using it until it is ready. |
Over here, (Ubuntu 18.04, erlang solutions erlang and elixir) creating a fresh project with
(here i changed the generated test a couple of times until I gave up) Switching back to version 0.9 however yields test output just as it used to be. Furthermore, I can confirm that when using version 1.0.1, I can get it to work when I manually edit the zombie_killer script to use bash instead of sh (as @grantwest and @vheathen also pointed out) |
That makes sense @lpil. Sorry for the issues, everyone! @grantwest, would you like to open an issue in |
Thanks for the excellent feedback everyone! What do we think about using bash instead of sh? Seeing as this is a dev tool I think that would be reasonable. |
I am having a problem with
zombie_killer
not actually running the tests. I have a standard Phoenix project and I am running in theelixir:1.9.2
docker container, which is debian based.I put a
set -x
at the beginning of my zombie_killer script and this is what I end up with:It never makes it to the rest of the script. But zombie_killer does finish running because I can see that is is no longer running
ps aux
. Also, the thing reruns if I change a file. I can also prove that the tests are not actually running by making one of the tests create a file and seeing that the file is not created.When I just run the mix command it works fine:
The absolute simplest way that I have found to solve this is to just change the first line of
zombie_killer
to#!/bin/bash
, but I am guessing not everyone is going to want bash.I see that
zombie_killer
was recently added, maybe @rjdellecese can weigh in?The text was updated successfully, but these errors were encountered: