Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file move to FileIO #1175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add file move to FileIO #1175

wants to merge 1 commit into from

Conversation

timmi-on-rails
Copy link
Contributor

@timmi-on-rails timmi-on-rails commented Jan 22, 2023 •
edited

Fix #1174

@timmi-on-rails timmi-on-rails changed the title Add file move to FileIO (#1174) Add file move to FileIO Jan 22, 2023
bmazzarol
bmazzarol reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@bmazzarol bmazzarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should move also be exposed on the static File module?

Just did not see it in the PR.

@timmi-on-rails
Copy link
Contributor Author

Oops, forgot about it.
Will complete later.

@timmi-on-rails
Copy link
Contributor Author

@bmazzarol I finally fixed it. Anything else?

bmazzarol
bmazzarol approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@bmazzarol bmazzarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmazzarol bmazzarol bmazzarol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileIO move missing?
3 participants
@timmi-on-rails @bmazzarol @TomOpenSource